Skip to content

Add check to ensure file index is used correctly #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 14, 2024
Merged

Add check to ensure file index is used correctly #333

merged 2 commits into from
Aug 14, 2024

Conversation

wbrannon
Copy link
Contributor

@wbrannon wbrannon commented Aug 14, 2024 •
edited by adamshapiro0
Loading

Fixes

  • Add check for when MixedLogReader is rewound in order to prevent a numerical overflow error
  • Set default next index element when file is being read from beginning

@wbrannon wbrannon added the bug Something isn't working label Aug 14, 2024
@wbrannon wbrannon requested a review from adamshapiro0 August 14, 2024 18:01
@wbrannon wbrannon self-assigned this Aug 14, 2024
adamshapiro0
adamshapiro0 approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@adamshapiro0 adamshapiro0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@wbrannon wbrannon merged commit 29786ba into master Aug 14, 2024
14 checks passed
@wbrannon wbrannon deleted the fix-index-update branch August 14, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamshapiro0 adamshapiro0 adamshapiro0 approved these changes

Assignees

@wbrannon wbrannon

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbrannon @adamshapiro0