Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the Parliamentary constituency data in dictionary form #2200

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

nikhilwoodruff
Copy link
Collaborator

Fixes #2199

@nikhilwoodruff nikhilwoodruff added the bug Something isn't working label Feb 23, 2025
@nikhilwoodruff nikhilwoodruff self-assigned this Feb 23, 2025
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

Attention: Patch coverage is 4.34783% with 22 lines in your changes missing coverage. Please review.

Project coverage is 74.21%. Comparing base (69fb911) to head (7249a85).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
policyengine_api/endpoints/economy/compare.py 4.34% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2200      +/-   ##
==========================================
- Coverage   75.59%   74.21%   -1.39%     
==========================================
  Files          79       79              
  Lines        2934     3021      +87     
  Branches      311      331      +20     
==========================================
+ Hits         2218     2242      +24     
- Misses        651      714      +63     
  Partials       65       65              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikhilwoodruff nikhilwoodruff merged commit 4c708b7 into master Feb 24, 2025
4 of 6 checks passed
@nikhilwoodruff nikhilwoodruff deleted the nikhilwoodruff/issue2199 branch February 24, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return the Parliamentary constituency data in dictionary form, not BaseModel
1 participant