-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UK country filters don't work with constituency outputs #2209
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2209 +/- ##
==========================================
+ Coverage 74.21% 75.42% +1.20%
==========================================
Files 79 81 +2
Lines 3021 3129 +108
Branches 331 343 +12
==========================================
+ Hits 2242 2360 +118
+ Misses 714 701 -13
- Partials 65 68 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you ask claude code to write some tests?
We also have an example set of testing best practices in |
Yes, done @MaxGhenis. And thanks @anth-volk- though given that this uses private UK data, I'll stick to unit tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @nikhilwoodruff! Love the increased test coverage from the tests you've included here.
Fixes #2208