Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UK country filters don't work with constituency outputs #2209

Merged
merged 4 commits into from
Feb 25, 2025

Conversation

nikhilwoodruff
Copy link
Collaborator

Fixes #2208

@nikhilwoodruff nikhilwoodruff added the bug Something isn't working label Feb 24, 2025
@nikhilwoodruff nikhilwoodruff self-assigned this Feb 24, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 98.26087% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.42%. Comparing base (210abe6) to head (772288e).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
...ures/jobs/test_calculate_economy_simulation_job.py 96.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2209      +/-   ##
==========================================
+ Coverage   74.21%   75.42%   +1.20%     
==========================================
  Files          79       81       +2     
  Lines        3021     3129     +108     
  Branches      331      343      +12     
==========================================
+ Hits         2242     2360     +118     
+ Misses        714      701      -13     
- Partials       65       68       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you ask claude code to write some tests?

@anth-volk
Copy link
Collaborator

We also have an example set of testing best practices in tests/unit/test_household_service.py

@nikhilwoodruff
Copy link
Collaborator Author

Yes, done @MaxGhenis. And thanks @anth-volk- though given that this uses private UK data, I'll stick to unit tests.

Copy link
Collaborator

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @nikhilwoodruff! Love the increased test coverage from the tests you've included here.

@nikhilwoodruff nikhilwoodruff merged commit ed7b32a into master Feb 25, 2025
6 checks passed
@nikhilwoodruff nikhilwoodruff deleted the nikhilwoodruff/issue2208 branch February 25, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UK country filters don't work with constituency outputs
3 participants