Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FTE impacts to labor supply and constituency outputs #2218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nikhilwoodruff
Copy link
Collaborator

Fixes #2217

@nikhilwoodruff nikhilwoodruff added the enhancement New feature or request label Feb 26, 2025
@nikhilwoodruff nikhilwoodruff self-assigned this Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

policyengine_api/endpoints/economy/compare.py:57

  • [nitpick] The variable name 'total_ftes' might be misinterpreted as a count rather than representing full-time equivalent labor; consider renaming it to something like 'total_fte' for clarity.
total_ftes = (

policyengine_api/jobs/tasks/compute_general_economy.py:206

  • [nitpick] The use of different simulation keys ("weekly_hours_worked" for the US and "hours_worked" for other cases) may lead to confusion; consider unifying or clearly documenting the intended data units to improve consistency.
            weekly_hours_hh = self.simulation.calculate("hours_worked") / 52
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.

Project coverage is 75.11%. Comparing base (c347b6e) to head (5e5faf4).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
policyengine_api/endpoints/economy/compare.py 10.00% 9 Missing ⚠️
...cyengine_api/jobs/tasks/compute_general_economy.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2218      +/-   ##
==========================================
- Coverage   75.39%   75.11%   -0.29%     
==========================================
  Files          81       81              
  Lines        3130     3143      +13     
  Branches      344      345       +1     
==========================================
+ Hits         2360     2361       +1     
- Misses        702      714      +12     
  Partials       68       68              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add FTE impacts to labor supply and constituency outputs
1 participant