Update simulation (for app v2) to store output for household calculations #2827
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2827 +/- ##
==========================================
- Coverage 77.03% 75.19% -1.85%
==========================================
Files 53 53
Lines 1903 1955 +52
Branches 243 252 +9
==========================================
+ Hits 1466 1470 +4
- Misses 387 435 +48
Partials 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SakshiKekre
force-pushed
the
fix/issue-226-household-simulation-outputs
branch
from
079d356 to
0422cdb
Compare
| policy_id INT NOT NULL | ||
| policy_id INT NOT NULL, | ||
| -- output_json stores calculation results for household simulations only | ||
| -- For geography simulations, outputs are stored in report_outputs table |
There was a problem hiding this comment.
nit: Can you say that it's for single-sim households (comparisons are still stored in report_outputs) and that for geo sims, it's because we don't have the API capability to calculate them separately?
| policy_id INT NOT NULL, | ||
| -- output_json stores calculation results for household simulations only | ||
| -- For geography simulations, outputs are stored in report_outputs table | ||
| output_json JSON DEFAULT NULL |
There was a problem hiding this comment.
nit: Same as for initialise.sql
| ) | ||
|
|
||
| if not success: | ||
| raise BadRequest("No fields to update") |
There was a problem hiding this comment.
nit, non-blocking: I think the message is wrong here maybe?
| """ | ||
| print(f"Updating simulation {simulation_id} with output") | ||
| # Automatically update api_version on every update to latest | ||
| api_version: str = COUNTRY_PACKAGE_VERSIONS.get(country_id) |
There was a problem hiding this comment.
accolade: Good catch, we do need this
2 participants
Fixes PolicyEngine/policyengine-app-v2#226
This PR
output_jsoncolumn tosimulationstable.PATCHendpoint to store household calculation outputs for each simulation.Note: The production database schema has been modified using