Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting SALT deduction to zero #171

Merged
merged 13 commits into from
Feb 13, 2025
Merged

Conversation

noman404
Copy link
Collaborator

@noman404 noman404 commented Jan 2, 2025

set salt_deduction 0.0 from cli argument

python policyengine_taxsim\cli.py input.csv --disable-salt

Fixes #160

@MaxGhenis
Copy link
Contributor

How does this compare to the taxsim approach?

@noman404
Copy link
Collaborator Author

noman404 commented Jan 2, 2025

How does this compare to the taxsim approach?

i do not have that idea, today we have a call with dan, will share this with him that is this approach works for him.

# Conflicts:
#	output/policyengine_taxsim_household_with_dependent_output.csv
#	output/policyengine_taxsim_household_with_dependent_single_parent_output.csv
#	output/policyengine_taxsim_joint_household_output.csv
#	output/policyengine_taxsim_single_household_output.csv
# Conflicts:
#	policyengine_taxsim/cli.py
@PavelMakarchuk
Copy link
Collaborator

Need to see whether we should also disable state level salt deductions to match TaxAct - my intuition is yes but confirming with Dan

@PavelMakarchuk
Copy link
Collaborator

Decided to set state_and_local_income_tax to zero instead of zero to disable state specific salt deductions to zero as well

@MaxGhenis MaxGhenis merged commit bc2cae4 into PolicyEngine:main Feb 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting SALT deduction to zero
3 participants