Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix local area calibration to include all income types #82

Merged
merged 5 commits into from
Feb 26, 2025
Merged

Fix local area calibration to include all income types #82

merged 5 commits into from
Feb 26, 2025

Conversation

nikhilwoodruff
Copy link
Contributor

Summary

  • Extended the local authority and constituency calibration to target all income types (self-employment, pension, and employment income) instead of just total income
  • Changed the loop in both loss.py files to use all variables in INCOME_VARIABLES instead of just the first one

Test plan

  • Run local authority and constituency calibration to verify the calibration works with all income variables

Fixes #81

🤖 Generated with Claude Code

@nikhilwoodruff
Fix local area calibration to include all income types
ad0a918 
Loop through all income variables in both local authority and constituency
calibration rather than just the first (total income). This ensures
self-employment income and pension income are included in the calibration.

Fixes #81

🤖 Generated with Claude Code
Co-Authored-By: Claude <[email protected]>
@nikhilwoodruff
Remove duplicate employment income targeting
9fc73bc
@nikhilwoodruff
Fix typo in CSV name
ba1b7ea
@nikhilwoodruff
Fix typo
23a39fa
@nikhilwoodruff
Fix bugs
17ed90b
@nikhilwoodruff nikhilwoodruff merged commit 5740360 into main Feb 26, 2025
2 checks passed
@nikhilwoodruff nikhilwoodruff deleted the fix-income-variable-calibration branch February 26, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend UK local authority calibration to include self-employment and pension income
1 participant
@nikhilwoodruff