Make minor changes and add docs for structural reforms #5427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you create a Colab Notebook with an example reform which can be accessed when checking out this PR - this can give me some room to test out different reform structures and edge cases but based on our conversation - the implementation will definitely simplify the reform creating process |
|
While I could create a Colab notebook, I'm not sure if it'd be possible to actually run the code, since successfully running this requires installing two locally modified packages, |
|
Forgot to write the second half of this. Would that be useful to you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR meant only for local testing purposes and should not be merged
@PavelMakarchuk I've worked up a Jupyter notebook in
docs/usage/new_structural_reforms.ipynbexplaining this first draft version of a new structural reform interface. I'd love your feedback and hope this doc serves as a guide as we continue refining this implementation.