Added YAML files for Age Curve and Rating Areas for SLCSP #5480
+6,055
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavelMakarchuk
changed the title
PavelMakarchuk
requested changes
Jan 14, 2025
There was a problem hiding this comment.
we want to use a single_amount type parameter
brackets:
- threshold:
2023-01-01: 0
amount:
2023-01-01: 1
- threshold:
2023-01-01: 21
amount:
2023-01-01: 1.5748
- threshold:
2023-01-01: 25
amount:
2023-01-01: 1.5811
- threshold:
2023-01-01: 30
amount:
2023-01-01: 1.7874
....
There was a problem hiding this comment.
metadata:
type: single_amount
amount_unit: /1
threshold_unit: year
....
There was a problem hiding this comment.
similar for all yaml files
| @@ -0,0 +1,215 @@ | |||
| description: Age curve factors for ACA premium pricing in Alabama, normalized to age | |||
There was a problem hiding this comment.
could you rename the file to alabama.yaml
There was a problem hiding this comment.
move to docs/gov/aca
and moved the file that generates the yamls
PavelMakarchuk
requested changes
Jan 15, 2025
| metadata: | ||
| type: single_amount | ||
| period: year | ||
| amount_unit: /1 |
There was a problem hiding this comment.
Suggested change
| amount_unit: /1 | |
| amount_unit: /1 | |
| threshold_unit: int |
| href: https://www.cms.gov/cciio/programs-and-initiatives/health-insurance-market-reforms/downloads/statespecagecrv053117.pdf | ||
| brackets: | ||
| - threshold: | ||
| '0000-01-01': 0 |
There was a problem hiding this comment.
Suggested change
| '0000-01-01': 0 | |
| 0000-01-01: 0 |
There was a problem hiding this comment.
All time period
And lets use a start date from the references
| reference: | ||
| - title: CMS Market Rating Reforms State Specific Age Curve Variations | ||
| href: https://www.cms.gov/cciio/programs-and-initiatives/health-insurance-market-reforms/downloads/statespecagecrv053117.pdf | ||
| values: |
There was a problem hiding this comment.
Suggested change
| values: |
| metadata: | ||
| type: amount | ||
| period: month | ||
| unit: USD/month |
There was a problem hiding this comment.
Suggested change
| unit: USD/month | |
| unit: currency-USD |
| @@ -0,0 +1,1043 @@ | |||
| description: Second Lowest Cost Silver Plan (SLCSP) premiums by rating area, normalized to age 0. | |||
| metadata: | |||
| type: amount | |||
There was a problem hiding this comment.
Suggested change
| type: amount |
MaxGhenis
changed the title
| else: | ||
| return household("county_fips", period) | ||
|
|
||
| class aca_slspc_trimmed_age(Variable): |
There was a problem hiding this comment.
lets make one class per file:
Lets make aca_slspc_trimmed_age a new .py file
There was a problem hiding this comment.
same for the other classes
PavelMakarchuk
requested changes
Jan 15, 2025
Comment on lines
+110
to
+111
| person_costs = tax_unit.members("person_aca_slspc", period) | ||
| return tax_unit.sum(person_costs) |
There was a problem hiding this comment.
Suggested change
| person_costs = tax_unit.members("person_aca_slspc", period) | |
| return tax_unit.sum(person_costs) | |
| return add(tax_unit, period, ["person_aca_slspc"] |
policyengine_us/variables/household/demographic/geographic/slspc.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Lets add unit tests for each individual file, - this will show whether the structure works - I might have more suggestions but would like to see test outputs
…pc.py Co-authored-by: Pavel Makarchuk <[email protected]>
PavelMakarchuk
requested changes
Jan 16, 2025
..._us/parameters/gov/hhs/medicaid/geography/standard_county_names/standardized_county_names.py
Outdated
Show resolved
Hide resolved
...engine_us/parameters/gov/hhs/medicaid/geography/standard_county_names/unmatched_counties.txt
Outdated
Show resolved
Hide resolved
| breakdown: | ||
| - state_code | ||
| - range(1, 67) | ||
| amount_unit:currency-USD |
There was a problem hiding this comment.
Suggested change
| amount_unit:currency-USD |
PavelMakarchuk
requested changes
Jan 17, 2025
| definition_period = MONTH | ||
|
|
||
| def formula(household, period, parameters): | ||
| state = household("state_code", period).decode_to_str() |
There was a problem hiding this comment.
Suggested change
| state = household("state_code", period).decode_to_str() | |
| state = person.household("state_code_str", period) |
|
|
||
| class slspc_age_adjusted_cost(Variable): | ||
| value_type = float | ||
| entity = Household |
There was a problem hiding this comment.
Suggested change
| entity = Household | |
| entity = Person |
| @@ -0,0 +1,28 @@ | |||
| from policyengine_us.model_api import * | |||
|
|
|||
| class slspc_age_adjusted_cost(Variable): | |||
There was a problem hiding this comment.
Suggested change
| class slspc_age_adjusted_cost(Variable): | |
| class slspc_age_adjusted_cost_person(Variable): |
|
|
||
| def formula(household, period, parameters): | ||
| state = household("state_code", period).decode_to_str() | ||
| age = household("age", period) |
There was a problem hiding this comment.
Suggested change
| age = household("age", period) | |
| age = person("monthly_age", period) |
| def formula(household, period, parameters): | ||
| state = household("state_code", period).decode_to_str() | ||
| age = household("age", period) | ||
| base_cost = household("slspc_baseline_cost_at_age_0", period) |
There was a problem hiding this comment.
Suggested change
| base_cost = household("slspc_baseline_cost_at_age_0", period) | |
| base_cost = person.household("slspc_baseline_cost_at_age_0", period) |
Comment on lines
+16
to
+28
| special_states = ["district_of_columbia", "alabama", "massachusetts", | ||
| "minnesota", "mississippi", "oregon", "utah"] | ||
| curve_name = state.lower() if state.lower() in special_states else "default" | ||
| age_curve = parameters.gov.aca.age_curves[curve_name] | ||
|
|
||
| # Find applicable bracket | ||
| brackets = age_curve.brackets | ||
| applicable_bracket = max( | ||
| (b for b in brackets if b.threshold <= age), | ||
| key=lambda b: b.threshold | ||
| ) | ||
|
|
||
| return base_cost * applicable_bracket.amount |
There was a problem hiding this comment.
Some suggestions for code:
p = parameters(period).gov.aca.age_curved
applicable_rate = select(
[ state_code == "AL",
state_code == "DC",
....],
[p.alabama.calc(age),
p.district_of_columbia.calc(age),
....],
default = p.default.calc(age),
)
return base_cost * applicable_rate
| @@ -0,0 +1,19 @@ | |||
| from policyengine_us.model_api import * | |||
|
|
|||
| class slspc_baseline_cost_at_age_0(Variable): | |||
There was a problem hiding this comment.
Suggested change
| class slspc_baseline_cost_at_age_0(Variable): | |
| class slspc_baseline_base_cost(Variable): |
| class slspc_baseline_cost_at_age_0(Variable): | ||
| value_type = float | ||
| entity = Household | ||
| label = "Second-lowest ACA silver-plan cost at age 0" |
There was a problem hiding this comment.
Suggested change
| label = "Second-lowest ACA silver-plan cost at age 0" | |
| label = "Second-lowest ACA silver-plan base cost" | |
| documentation = "Second-lowest ACA silver-plan cost at age 0" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5037