Repository navigation
Version app assets to prevent deploy-skew rendering - #22
Merged
Merged
Conversation
A deploy can leave a browser holding cached app.js against fresh index.html (or stale data against fresh code), which rendered the national table visually off by a column during the FY 2025 lens rollout. Assets now carry a shared cache-buster: index.html loads app.js?v=<stamp>, app.js declares the same stamp as ASSET_V and appends it to every data fetch, and a test locks the two in step so a deploy that bumps one without the other fails CI. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the off-by-a-column report from the FY 2025 lens rollout: production markup and row templates are structurally aligned (verified 7-over-7 with 0px header/cell offsets), so the skew was a cached old app.js rendering six cells under the new seven-header table. Assets now share a
?v=stamp — index.html's script tag and app.js'sASSET_Vconstant, applied to every data fetch — with a lockstep test so bumping one without the other fails CI. Bump the stamp on any deploy that changes an asset.🤖 Generated with Claude Code