Introducing websockets - EARLY BETA, DO NOT USE THEM! #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…E for more information.
|
Do not merge yet (note to myself I guess?) |
Closed
|
I guess it's ready to be merged. Everything is working. Missing some server side optimization before the official release though. |
Closed
|
Fixed a few small issues (didn't push yet), still doing a bit of testing then we'll be able to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
DO NOT USE THIS BRANCH!
WEBSOCKETS ARE IN EARLY BETA AND REQUIRE A SPECIAL AUTHENTICATION ON THE API
LAUNCHING THIS VERSION MIGHT RESULT IN A BAN FROM THE API
PLEASE USE THE
mainBRANCH INSTEAD!Working except for the skin part, when loading players with the websocket after 3 players the skin system will crash (some internal thread issue with pyqt and the websocket, because the websocket is on another thread...), for the time being skin loading has been disabled for players loaded via the websocket.