Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing to Add note names to piano keys. #227

Closed
wants to merge 16 commits into from

Conversation

guylamar2006
Copy link
Contributor

No description provided.

@guylamar2006 guylamar2006 marked this pull request as draft December 1, 2024 15:13
@guylamar2006 guylamar2006 deleted the patch-2 branch December 1, 2024 16:12
@PolyMeilex
Copy link
Owner

FYI you are editing settings page widget for selecting piano range. My assumption is that you in fact trying to add labels in the gameplay itself, code for this is here:

for key in self.layout.keys.iter().filter(|key| key.note_id() == 0) {

It already labels C notes, but by editing the filter condition, you should be able to display labels for all keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants