fix(examples): add missing tracing requirements - #95
Open
qiuqiuaiweb3 wants to merge 1 commit into
Open
Conversation
qiuqiuaiweb3
marked this pull request as ready for review
July 21, 2026 02:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tracingto the declaredrequired-featuresof nine examples that import it unconditionally.clob,clob,ws, orclob,rfqfeature sets.Reproduction and cause
On current
main(222143d321eba97d5711a848265eb9aab3bc7ff4), the affected examples fail withE0432: unresolved import tracingwhen checked with their currently declared features. The nine targets are:async,authenticated,aws_authenticated, andbuilder_authenticatedunderclob;websocket_orderbook,websocket_user, andwebsocket_unsubscribeunderclob,ws;rfq_quotesandrfq_requestsunderclob,rfq.Each source imports
tracingunconditionally, buttracingis an optional dependency and none of those three base feature groups enables it. The existing default checks skip these examples, while all-feature checks enabletracingand mask the manifest gap.PR #80 previously documented this separate issue while leaving it out of its rustls-provider diff. This PR only implements the isolated manifest correction.
Verification
I reproduced all nine failures on both current main and a fresh crates.io 0.7.0 extraction. Adding
tracingmade all 18 controls compile. With this patch:tracingfor all nine targets;target requires ... tracinginstead of reaching rustc;clob,ws,rfqcheck/test, default tests, all-target/all-feature build, both strict clippy configurations, pinned-nightly formatting, cargo-sort, coverage, and all pre-commit hooks pass.I used an AI coding assistant to help reproduce the matrix, prepare the manifest-only patch, and run verification. I reviewed the final diff and this description.
Note
Low Risk
Cargo manifest alignment only; no runtime, security, or public API impact.
Overview
Manifest-only fix: nine
[[example]]targets inCargo.tomlnow listtracingalongside their existing feature sets (clob,clob,ws, orclob,rfq).Those examples already import
tracingunconditionally whiletracingstays an optional crate feature not pulled in byclob,ws, orrfqalone. Without this change, building with only those feature groups could hitE0432: unresolved import tracing; Cargo should now refuse incomplete feature sets instead of compiling broken example targets.No example sources, dependencies, lockfile, or library API behavior change.
Reviewed by Cursor Bugbot for commit 387a254. Bugbot is set up for automated code reviews on this repo. Configure here.