Skip to content

fix error when passing an undefined value #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix error when passing an undefined value #206

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
268fc2a
fix error when passing an undefined value
kudarap May 11, 2016
1f17da9
Update iron-request.html
kudarap May 18, 2016
9ad2038
Update iron-request.html
kudarap May 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions iron-request.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,11 @@
* @return {string} .
*/
_wwwFormUrlEncodePiece: function(str) {
// Support undefined input
if (typeof(str) == 'undefined' || !str) {
return '';
}

// Spec says to normalize newlines to \r\n and replace %20 spaces with +.
// jQuery does this as well, so this is likely to be widely compatible.
return encodeURIComponent(str.toString().replace(/\r?\n/g, '\r\n'))
Expand Down