Pipe label through to aria-labels #549
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@notwaldorf PTAL |
|
@robdodson paper-textarea tests are red |
|
@robdodson ping ping ping? let's get this boat merged! |
|
@notwaldorf I'd really like to help but I don't think I have time to dig into all of these test failures :\ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipe label through as
aria-label. This (i think) removes the need for theupdateAriaLabelledbycode. Specially this change is intended to fix an issue with paper-textarea. Because there is a shadow boundary between the textarea and paper-textarea, using aria-labelledby doesn't work. This PR depends on PolymerElements/iron-autogrow-textarea#108 being merged first.