Alpha into master #288
Closed
Alpha into master #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add Local and Postgres repositories for subscriptions and notifications
add needed subquery extension to the DB
- Modifies endpoints
1. `POST venues/create` to support optional property `signers` in the request body
(`CreateVenueDto`) to specify list of addresses allowed to sign off chain receipts
for instructions of the venue
2. `POST venues/:id/instructions/create`
a. to support new optional attribute `endAfterBlock` in request body
(`CreateInstructionDto`)to allow creation of instruction that can be executed
manually after this given block.
b. to add support for off chain legs by adding new optional type
`OffChainLegDto` to type of legs
3. `POST instructions/:id/affirm` to support optional attributes `portfolios`
and `receipts` in the request body (`AffirmInstructionDto`) to specify specific
portfolios to affirm or the details of the off chain leg receipt to be used to
affirm off chain legs
- Adds new endpoints
1. `POST venues/:id/add-signers` and `POST venues/:id/remove-signers` to
add/remove allowed signers from a Venue
2. `GET accounts/:id/receipts` to get all off chain receipts redeemed by an
account
3. `GET instructions/:id/offchain-affirmations` to fetch all off chain
affirmations status for all off chain legs in an instruction
4. `GET instructions/:id/offchain-affirmations/:legId` to fetch off chain
affirmation status for a specific leg in an instruction
5. `POST instructions/:id/execute-manually` to execute an instruction manually
when artemis is not configured an in memory implementation will be used so that AMQP process mode can be used in dev
`createCdd` would always be false, even when specified in the request. Adds a decorator to DTO param so `createCdd` is parsed properly
When a multiSig signer submits a transaction it will be wrapped and a `proposal` field will be present in the response (or `multiSig` field present will be in offline payloads)
add endpoints to create and modify multiSigs, get proposal details and approve/reject them
polymath-eric
requested review from
VictorVicente,
prashantasdeveloper and
sansan
as code owners
|
sansan
approved these changes
Aug 29, 2024
prashantasdeveloper
approved these changes
Sep 3, 2024
VictorVicente
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Link
N/A
Changelog / Description
Release bug fixes, multi sig support and off chain legs
Checklist -