Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 add link ticker to asset ID method #1277

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

polymath-eric
Copy link
Collaborator

Description

add linkTicker method to asset entity. Allows linking ticker to an asset on v7.0 chains

Breaking Changes

JIRA Link

Checklist

  • Updated the Readme.md (if required) ?

@polymath-eric polymath-eric requested a review from a team as a code owner August 23, 2024 13:39
Base automatically changed from feat/update-polkadot-types-7.0 to 7.0-release August 25, 2024 16:36
const transactions = [TxTags.asset.LinkTickerToAssetId];

if (status === TickerReservationStatus.Free) {
transactions.push(TxTags.asset.RegisterUniqueTicker); // not sure if register is needed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be needed. It's good to extend the functionality that if someone is trying to link a free ticker, we allow that too

@prashantasdeveloper
Copy link
Collaborator

/fast-forward

@prashantasdeveloper
Copy link
Collaborator

Triggered from #1277 (comment) by @​prashantasdeveloper.

Trying to fast forward 7.0-release (d8908de) to link-ticker (1eb6cf1).

Target branch (7.0-release):

commit d8908de1d202bfef841391276f131172178b6d9c (HEAD -> 7.0-release, origin/7.0-release)
Author: Prashant Bajpai <[email protected]>
Date:   Wed Aug 21 11:27:32 2024 +0530

    test: 💍 add tests for coverage

Pull request (link-ticker):

commit 1eb6cf1ec2da9250c3782e7ce1c2dcefd62051a3 (pull_request/link-ticker)
Author: Eric Richardson <[email protected]>
Date:   Wed Aug 21 17:11:20 2024 -0400

    feat: 🎸 add link ticker to asset ID method
    
    add `linkTicker` method to asset entity. Allows linking ticker to an
    asset on v7.0 chains

Can't fast forward 7.0-release (d8908de) to link-ticker (1eb6cf1). 7.0-release (d8908de) is not a direct ancestor of link-ticker (1eb6cf1). Branches appear to have diverged at cf722f6:

* d8908de1d202bfef841391276f131172178b6d9c test: 💍 add tests for coverage
| * 1eb6cf1ec2da9250c3782e7ce1c2dcefd62051a3 feat: 🎸 add link ticker to asset ID method
| * 5823c250bea925a8861673ae9194b7f5171a361e test: 💍 add tests for coverage
|/  
* cf722f663a5f009b63489387508bd6f85f26a225 test: 💍 update broken tests

commit cf722f663a5f009b63489387508bd6f85f26a225
Author: Prashant Bajpai <[email protected]>
Date:   Tue Aug 20 16:13:04 2024 +0530

    test: 💍 update broken tests

Rebase locally, and then force push to link-ticker.

add `linkTicker` method to asset entity. Allows linking ticker to an
asset on v7.0 chains
Copy link

sonarcloud bot commented Aug 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
96.6% Coverage on New Code (required ≥ 100%)
11 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@prashantasdeveloper prashantasdeveloper merged commit 4c82ebf into 7.0-release Aug 25, 2024
10 of 11 checks passed
@prashantasdeveloper prashantasdeveloper deleted the link-ticker branch August 25, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants