-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 🎸 add link ticker to asset ID method #1277
Conversation
5823c25
to
d8908de
Compare
const transactions = [TxTags.asset.LinkTickerToAssetId]; | ||
|
||
if (status === TickerReservationStatus.Free) { | ||
transactions.push(TxTags.asset.RegisterUniqueTicker); // not sure if register is needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be needed. It's good to extend the functionality that if someone is trying to link a free ticker, we allow that too
/fast-forward |
Triggered from #1277 (comment) by @prashantasdeveloper. Trying to fast forward Target branch ( commit d8908de1d202bfef841391276f131172178b6d9c (HEAD -> 7.0-release, origin/7.0-release)
Author: Prashant Bajpai <[email protected]>
Date: Wed Aug 21 11:27:32 2024 +0530
test: 💍 add tests for coverage Pull request ( commit 1eb6cf1ec2da9250c3782e7ce1c2dcefd62051a3 (pull_request/link-ticker)
Author: Eric Richardson <[email protected]>
Date: Wed Aug 21 17:11:20 2024 -0400
feat: 🎸 add link ticker to asset ID method
add `linkTicker` method to asset entity. Allows linking ticker to an
asset on v7.0 chains Can't fast forward * d8908de1d202bfef841391276f131172178b6d9c test: 💍 add tests for coverage
| * 1eb6cf1ec2da9250c3782e7ce1c2dcefd62051a3 feat: 🎸 add link ticker to asset ID method
| * 5823c250bea925a8861673ae9194b7f5171a361e test: 💍 add tests for coverage
|/
* cf722f663a5f009b63489387508bd6f85f26a225 test: 💍 update broken tests
commit cf722f663a5f009b63489387508bd6f85f26a225
Author: Prashant Bajpai <[email protected]>
Date: Tue Aug 20 16:13:04 2024 +0530
test: 💍 update broken tests Rebase locally, and then force push to |
add `linkTicker` method to asset entity. Allows linking ticker to an asset on v7.0 chains
1eb6cf1
to
4c82ebf
Compare
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Description
add
linkTicker
method to asset entity. Allows linking ticker to an asset on v7.0 chainsBreaking Changes
JIRA Link
Checklist