Skip to content

Conversation

oscfdezdz
Copy link
Contributor

Description

Mark the strings listed in the application and any other hard-coded strings as translatable. Also drops the ending periods from some strings for consistency with the rest.

Related Issue

#178

Type of change

Bug fix

Pull Request checklist

  • The commit message uses the conventional commiting method.
  • Made sure that your PR is not duplicate
  • Tests: This PR includes thorough tests or an explanation of why it does not (for bug
    fixes/features). Your PR should pass all CI checks in our Gtihub
    Actions Workflow
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of
    why it does not (optional)

Also drops the ending periods from some strings for consistency with the rest.
Copy link
Member

@starry-shivam starry-shivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Thanks a lot for your contribution :)

@starry-shivam starry-shivam merged commit 8b96085 into Pool-Of-Tears:main Sep 3, 2025
1 check passed
@oscfdezdz oscfdezdz deleted the missing-strings branch September 3, 2025 14:18
starry-shivam pushed a commit that referenced this pull request Sep 11, 2025
Also drops the ending periods from some strings for consistency with the rest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants