Add Copy button for GoalInfoScreen notes card
#95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple UI feature to copy notes for goal into a clipboard. Button can be found after expanding the note card in the 'GoalInfoScreen'.
Displays taost message feedback if device API is 32 or below (before Android 13)
|
May need extra edits for translations but otherwise think the main functionality is complete. |
starry-shivam
requested changes
Apr 7, 2024
app/src/main/java/com/starry/greenstash/ui/common/ExpandableCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/starry/greenstash/ui/common/ExpandableCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/starry/greenstash/ui/common/ExpandableCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/starry/greenstash/ui/common/ExpandableCard.kt
Outdated
Show resolved
Hide resolved
- Renames current new string resources to match previous ones in Goal Info Screen; - Adds another new resource for Icon description.
starry-shivam
requested changes
Apr 7, 2024
|
Alright! Things look pretty good to me now. Please clarify what you want to do about translations. |
|
Nvm, Got your response in the above comment. |
starry-shivam
approved these changes
Apr 7, 2024
|
Merged! Thanks again for contributing 🎉 |
|
Thanks for accepting my contribution 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a button for copying text from Note card in goal info screen.
Closes #94