This repository was archived by the owner on Jan 19, 2026. It is now read-only.
fix: remove redundant try catch - #53
Merged
Merged
Conversation
joshsny
requested review from
Copilot and
jonathanlab
and removed request for
Copilot
July 22, 2025 11:58
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes a redundant try-catch block that was wrapping error response parsing logic without providing meaningful error handling. The try-catch was silently swallowing any JSON parsing errors and proceeding to the generic error throw regardless.
- Removes unnecessary try-catch wrapper around error response JSON parsing
- Simplifies error handling flow by allowing JSON parsing errors to propagate naturally
This was referenced Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was meant to make it into the last one