Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update content-security-policy.md #9173

Closed
wants to merge 1 commit into from
Closed

Update content-security-policy.md #9173

wants to merge 1 commit into from

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Aug 14, 2024

Changes

Originally raised in https://posthoghelp.zendesk.com/agent/tickets/16225

Add proxy host to suggested CSP

Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog ✅ Ready (Inspect) Visit Preview Aug 14, 2024 5:07pm

@daibhin
Copy link
Contributor Author

daibhin commented Aug 15, 2024

@raquelmsmith tagging you two because I saw that you recently changed from internal-e to internal-t. Do you have a good sense if customers should be adding this to their CSP?

@frankh
Copy link
Contributor

frankh commented Aug 15, 2024

this is only used by posthog (the company, as a user of posthog services), so shouldn't be added here - customers should never use this

@frankh frankh closed this Aug 15, 2024
@daibhin
Copy link
Contributor Author

daibhin commented Aug 19, 2024

It is inadvertently called from a customers site via the toolbar:
https://github.com/PostHog/posthog/blob/00dd4e8028b12e981e7d70d6a2ad05766b6a69db/frontend/src/toolbar/toolbarPosthogJS.ts#L9

Should they need to add it to their CSP in that case?

@daibhin daibhin reopened this Aug 19, 2024
@daibhin
Copy link
Contributor Author

daibhin commented Aug 21, 2024

Resolved this internally. The toolbar does make calls to internal-t to track it's own events e.g. toolbar loaded. Thinking is this isn't important enough to add it to the general CSP list, especially given people can change the window.JS_POSTHOG_HOST variable to us.i.posthog.com if they want

@daibhin daibhin closed this Aug 21, 2024
@daibhin daibhin deleted the daibhin-patch-1 branch August 21, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants