Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(feature flags docs): clarify "Persist flag" option #9210

Merged
merged 8 commits into from
Aug 20, 2024
Merged

chore(feature flags docs): clarify "Persist flag" option #9210

merged 8 commits into from
Aug 20, 2024

Conversation

jurajmajerik
Copy link
Contributor

@jurajmajerik jurajmajerik commented Aug 20, 2024 •
edited
Loading

Changes

The feature flag option Persist feature flag across authentication steps is not worthwhile for most users. We need to highlight this fact better.

Checklist

  • Words are spelled using American English
  • Titles are in sentence case
  • Feature names are in **[sentence case too]([https://apastyle.apa.org/style-grammar-guidelines/capitalization/title

@vercel Vercel
Copy link

vercel bot commented Aug 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog 🛑 Canceled (Inspect) Aug 20, 2024 3:56pm

PostHog and others added 3 commits August 20, 2024 10:21
@jurajmajerik
Copy link
Contributor Author

@ivanagas would appreciate a quick look on formatting etc :)

@jurajmajerik jurajmajerik mentioned this pull request Aug 20, 2024
Merged
ivanagas
ivanagas reviewed Aug 20, 2024
View reviewed changes
Copy link
Contributor

@ivanagas ivanagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

contents/docs/feature-flags/creating-feature-flags.mdx Outdated Show resolved Hide resolved
contents/docs/feature-flags/creating-feature-flags.mdx Outdated Show resolved Hide resolved
contents/docs/feature-flags/creating-feature-flags.mdx Outdated Show resolved Hide resolved
contents/docs/feature-flags/creating-feature-flags.mdx Outdated Show resolved Hide resolved
@jurajmajerik jurajmajerik enabled auto-merge (squash) August 20, 2024 15:38
@jurajmajerik jurajmajerik merged commit 50c5d80 into master Aug 20, 2024
3 checks passed
@jurajmajerik jurajmajerik deleted the flag-persitence-docs-update branch August 20, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanagas ivanagas ivanagas left review comments

@neilkakkar neilkakkar neilkakkar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jurajmajerik @neilkakkar @ivanagas