chore(err): re-work handle_event to be handle_events #28828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
daibhin
approved these changes
Feb 18, 2025
| // We need a cloned frame to move into the closure below | ||
| let frame = frame.clone(); | ||
|
|
||
| let context = context.clone(); |
There was a problem hiding this comment.
Why do we need to clone the context? I'm assuming it's because it needs to go across some async boundary in the task
There was a problem hiding this comment.
Yep, we async move so the spawn'd task needs to own the captured variables. The context in this case is just an Arc though, so the clone is cheap
Co-authored-by: David Newell <[email protected]>
HamedMP
pushed a commit
that referenced
this pull request
Feb 19, 2025
Co-authored-by: David Newell <[email protected]>
HamedMP
pushed a commit
that referenced
this pull request
Feb 25, 2025
Co-authored-by: David Newell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should be a significant improvement, most notably because it only resolves the issue once per fingerprint, instead of running issue resolution on every event. It also tries to be more cleverer about frame resolution, but that might turn out to be a mistake, I'm not sure yet.
If this does actually improve throughput notably, I'll refactor it to be a bit more composable, but since this might have no impact and be immediately reverted, I'd rather merge and see.