feat: add link from live events view to explore view #29349
Conversation
clicking on a live event will take you to the explore view filtered for that specific event (so you can check when its been ingested)
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added a feature that links live events to the explore view, allowing users to click on an event to see it filtered by UUID in the explore interface.
- Added
Linkcomponent inLiveEventsTable.tsxto make events clickable in the live events table - Implemented URL construction with encoded JSON query parameters to filter events by their UUID
- Created search URL that directs to
ActivityTab.ExploreEventswith a DataTableNode query configuration - Added proper imports for
Link,ActivityTab, andPropertyOperatortypes needed for the implementation
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
| propertiesViaUrl: true | ||
| }))}` | ||
| return ( | ||
| <Link to={searchUrl}> |
There was a problem hiding this comment.
We should instead implement the "Copy link to event" pattern, because this inline link fundamentally doesn't work: at the point in time the user sees a live event come in, that event does not yet exist in ClickHouse for a minute or so (depending on ingestion lag), so this link is effectively a 404
There was a problem hiding this comment.
right, that's why i made it a search instead of direct to the event, so you can search and refresh until it comes in - maybe we just need a user friendly way of telling users that it might be delayed though
copy link to event has the same issue right?
There was a problem hiding this comment.
ok, in the end i went with your way 1) for consistency, and 2) because we already have a tooltip on the event name and adding a second tooltip didn't work - and i wanted the warning tooltip saying it might not show up
see screenshot!
|
Size Change: +2 B (0%) Total Size: 9.73 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Problem
clicking on a live event will take you to the explore view filtered for that specific event (so you can check when its been ingested)
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?