Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(err): capture merge metric + ui changes #29370

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

oliverb123
Copy link
Contributor

Looks like this now (no hover needed for checkmark, merge always showing so you know its an option)

image

@oliverb123 oliverb123 requested a review from daibhin February 28, 2025 18:02
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR enhances the error tracking feature with event tracking and UI improvements for issue management.

  • Added posthog.capture('error_tracking_issue_merged', { primary: primaryIssue.id }) in errorTrackingDataNodeLogic.tsx to track merge events
  • Simplified UI by making issue selection checkboxes always visible instead of only on hover
  • Consolidated merge functionality into ErrorTrackingListOptions component with a persistent "Merge Issues" button
  • Added an "Unselect all" button that appears when issues are selected
  • Implemented sticky positioning with flex layout that separates action buttons from filters

3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

github-actions bot commented Feb 28, 2025

Size Change: 0 B

Total Size: 9.73 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 9.73 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants