feat: move waterfall view #29390
feat: move waterfall view #29390
Conversation
| import type { playerSidebarLogicType } from './playerSidebarLogicType' | ||
|
|
||
| export const playerSidebarLogic = kea<playerSidebarLogicType>([ | ||
| path(() => ['scenes', 'session-recordings', 'player', 'playerSidebarLogic']), | ||
| props({} as SessionRecordingPlayerLogicProps), |
There was a problem hiding this comment.
this doesn't ever get passed any props
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR moves the waterfall view from a separate playback mode to a tab in the session recording player sidebar, making it more accessible to users who were previously getting stuck in it.
- Added
NETWORK_WATERFALLtoSessionRecordingSidebarTabenum infrontend/src/types.tsand implemented it as a new tab in the sidebar - Removed
PlaybackModeenum and related functionality fromplayerSettingsLogic.tsas it's no longer needed - Modified
NetworkView.tsxto retrieve the session recording ID fromsessionRecordingPlayerLogicinstead of props - Added
splitKebabCaseutility function infrontend/src/lib/utils.tsxto improve display of kebab-cased tab names - Removed 'Playback mode' settings from
SessionRecordingsPlaylistSettings.tsxas the waterfall view is now a tab
9 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
frontend/src/scenes/session-recordings/player/sidebar/PlayerSidebarTab.tsx
Show resolved
Hide resolved
|
Size Change: -79 B (0%) Total Size: 9.73 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
we hid waterfall view to make our lives easier at the time, but folk keep getting stuck in it
let's make it a tab of the player