Update BillingViewSet #39047
Closed
Update BillingViewSet #39047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasen-posthog
requested changes
Oct 6, 2025
Contributor
yasen-posthog
left a comment
yasen-posthog
left a comment
There was a problem hiding this comment.
This proxy-like endpoint looks good overall, just needs some validation.
Also a couple of other stuff:
- Do we want a couple of simple tests, it's billing after all, so we need to have safety nets?
- The PR is in Draft, you may want to change that.
| def subscription_switch_plan(self, request: Request, *args: Any, **kwargs: Any) -> HttpResponse: | ||
| organization = self._get_org_required() | ||
| billing_manager = self.get_billing_manager() | ||
| res = billing_manager.switch_plan(organization, request.data) |
Contributor
There was a problem hiding this comment.
Should we add a validation here, similar to this?
Contributor
Author
Main validation and tests are in billing repo, this one's just a proxy. I don't think it requires tests, but I'll check how it works for other billing endpoints. |
Contributor
Author
|
Gonna close this PR, decided to merge it together with the UI, so it's easier to test locally: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Proxy for billing switch plan API: https://github.com/PostHog/billing/pull/1519