-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(array): temporal workflow for sandbox environment #39082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…posthog into array/sandbox-snapshots
products/tasks/backend/temporal/process_task/activities/tests/test_clone_repository.py
Dismissed
Show dismissed
Hide dismissed
products/tasks/backend/temporal/process_task/activities/tests/test_clone_repository.py
Dismissed
Show dismissed
Hide dismissed
…with creating sandboxes from a snapshot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (2)
-
products/tasks/backend/models.py, line 270 (link)logic: Using dict() as default can cause shared mutable state issues. Consider using None as default
Context Used: Context from
dashboard- Use 'None' as the default value for JSONField in models instead of 'dict()' to avoid creating a new ... (source) -
products/tasks/backend/models.py, line 512 (link)logic: Using dict() as default can cause shared mutable state issues. Consider using None as default
Context Used: Context from
dashboard- Use 'None' as the default value for JSONField in models instead of 'dict()' to avoid creating a new ... (source)
47 files reviewed, 35 comments
products/tasks/backend/temporal/process_task/activities/tests/test_create_snapshot.py
Show resolved
Hide resolved
products/tasks/backend/temporal/process_task/activities/inject_personal_api_key.py
Show resolved
Hide resolved
products/tasks/backend/temporal/process_task/activities/tests/test_get_sandbox_for_setup.py
Show resolved
Hide resolved
products/tasks/backend/temporal/process_task/activities/tests/test_get_sandbox_for_setup.py
Show resolved
Hide resolved
products/tasks/backend/temporal/process_task/activities/track_workflow_event.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a light scan of this - mostly looks good to me. We need to go back and make sure we clean up all of the files for workflows once we merge this and its working
Migration SQL ChangesHey 👋, we've detected some migrations on this PR. Here's the SQL output for each migration, make sure they make sense:
|
🔍 Migration Risk AnalysisWe've analyzed your migrations for potential risks. Summary: 1 Safe | 0 Needs Review | 0 Blocked ✅ SafeNo locks, backwards compatible |
Problem
We will be running tasks in a sandbox environment, the existing temporal workflow was running within the temporal worker.
Changes
Added a temporal workflow for executing the tasks in a sandbox environment, it follows the following flow:
a. Provision sandbox for setup
b. Clone repository
c. Run setup commands (install dependencies)
d. Create snapshot for reuse
e. Cleanup setup sandbox