-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: adding copy functionality for table results in OutputPane #39095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: adding copy functionality for table results in OutputPane #39095
Conversation
- Introduced a dropdown menu for copying table results in CSV, JSON, and Excel formats. - Added utility functions for clipboard operations and a helper function to create data table queries. - Enhanced the OutputPane component to support new copy features, improving user experience in data export.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 2 comments
Size Change: 0 B Total Size: 3.07 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Big fan of copying results 🚀
Perhaps wait for @PostHog/team-data-warehouse's review, as they have more experience in this area.
One comment: It is worth testing larger result sets (e.g, 50k lines + many columns). I've seen in the past that when implementing this copy feature, it would freeze the screen/OOM.
I think is valid to test that or put behind a FF for a while because those tickets would probably go to DW, so it is their call.
@lricoy agree, I think there is a limit of 100 always to display in the table though |
@lricoy tested with a limit 50k from the events table and I was able to copy/paste without crashing my mac 🤣 |
Oh, right, it is capped at 1k it seems |
Problem
Sometimes I would like to easily export result without actually having to export it, I would just want to copy them.
Changes
How did you test this code?
Mannually:
CSV:
JSON
EXCEL: