fix(experiments): Unify fonts (1) #39106
Merged
+22
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
frontend/src/scenes/experiments/MetricsView/new/MetricRowGroup.tsx
Outdated
Show resolved
Hide resolved
frontend/src/scenes/experiments/MetricsView/new/MetricRowGroup.tsx
Outdated
Show resolved
Hide resolved
|
Size Change: 0 B Total Size: 3.07 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated15 snapshot changes in total. 0 added, 15 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated11 snapshot changes in total. 0 added, 11 modified, 0 deleted:
Triggered by this commit. |
andehen
approved these changes
Oct 6, 2025
carlos-marchal-ph
pushed a commit
that referenced
this pull request
Oct 6, 2025
adamleithp
pushed a commit
that referenced
this pull request
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We're using all sorts of different fonts in the Experiments UI, and would be nice to make them consistent. I'll do this in multiple passes.
Changes
We have a standard way for formatting text in
LemonTablecomponent, which is used in many places in the Experiments UI. Let's use the same font style in the Metrics table and the Exposures collapsible header.How did you test this code?