Skip to content

fix(flags): Added if check and return error for filters with empty groups fix#38896 #39110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −0
Open

fix(flags): Added if check and return error for filters with empty groups fix#38896 #39110

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23a064b
Added if check and return error for filters with empty groups
Oct 3, 2025
0f8453d
Apply suggestion from @greptile-apps[bot]
gustavohstrassburger Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions posthog/api/feature_flag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,12 @@ def validate_filters(self, filters):
# mypy cannot tell that self.instance is a FeatureFlag
return self.instance.filters

groups = filters.get("groups", [])
if isinstance(groups, list) and len(groups) == 0:
raise serializers.ValidationError(
"Feature flag filters must contain at least one condition set. Empty 'groups' array is not allowed."
)

aggregation_group_type_index = filters.get("aggregation_group_type_index", None)

def properties_all_match(predicate):
Expand Down
Loading