Skip to content

Conversation

jabahamondes
Copy link
Contributor

@jabahamondes jabahamondes commented Oct 3, 2025

WIP

Blocked by #38856

Problem

Changes

How did you test this code?

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Changelog: (features only) Is this feature complete?

Javier Bahamondes and others added 7 commits September 30, 2025 10:00
….com:PostHog/posthog into feat/adding-tiktok-ads-integration-squeleton
…a fetching

- Added TikTok Ads as a new integration in the system.
- Implemented OAuth flow for TikTok Ads, including credential validation and token management.
- Created settings and configuration for TikTok Ads endpoints.
- Developed utility functions for flattening TikTok report data and handling pagination.
- Added tests for the TikTok Ads source and utility functions to ensure functionality and correctness.
- Included date chunking logic to comply with TikTok's API limits.

This integration allows users to collect campaign data and advertising metrics from TikTok Ads, enhancing our data import capabilities.
@posthog-bot
Copy link
Contributor

Hey @jabahamondes! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (1)

  1. frontend/src/lib/integrations/utils.ts, line 45 (link)

    style: Missing case for 'tiktok-ads' in getIntegrationNameFromKind function. This will display as 'Tiktok-ads' instead of 'TikTok Ads'. Consider adding: case 'tiktok-ads': return 'TikTok Ads'

18 files reviewed, 7 comments

Edit Code Review Agent Settings | Greptile

@jabahamondes jabahamondes marked this pull request as draft October 3, 2025 17:08
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Size Change: +12 B (0%)

Total Size: 3.07 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 3.07 MB +12 B (0%)

compressed-size-action

@posthog-bot posthog-bot requested a review from a team October 3, 2025 17:16
@jabahamondes jabahamondes removed the request for review from a team October 3, 2025 17:43
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Migration SQL Changes

Hey 👋, we've detected some migrations on this PR. Here's the SQL output for each migration, make sure they make sense:

posthog/migrations/0868_alter_externaldatasource_source_type.py

BEGIN;
--
-- Alter field source_type on externaldatasource
--
-- (no-op)
COMMIT;

Copy link
Contributor

github-actions bot commented Oct 3, 2025

🔍 Migration Risk Analysis

We've analyzed your migrations for potential risks.

Summary: 0 Safe | 1 Needs Review | 0 Blocked

⚠️ Needs Review

May have performance impact

posthog.0868_alter_externaldatasource_source_type
  └─ #1 ⚠️ AlterField
     Field alteration may cause table locks or data loss (check if changing type or constraints)
     model: externaldatasource, field: source_type, field_type: CharField

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants