Skip to content

fix: Don't strip underscores from variables #39121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2025
Merged

fix: Don't strip underscores from variables #39121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
277ea60
Don't strip underscores
gewenyu99 Oct 3, 2025
355b75a
update variables in API
gewenyu99 Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions frontend/src/queries/nodes/DataVisualization/Components/Variables/NewVariableModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ const getCodeName = (name: string): string => {
return (
name
.trim()
// Filter out all characters that is not a letter, number or space
.replace(/[^a-zA-Z0-9\s]/g, '')
// Filter out all characters that is not a letter, number or space or underscore
.replace(/[^a-zA-Z0-9\s_]/g, '')
Copy link
Member

@Gilbert09 Gilbert09 Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does https://github.com/PostHog/posthog/blob/master/posthog/api/insight_variable.py#L22-L24 need updating as well?

Copy link
Contributor Author

@gewenyu99 gewenyu99 Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops good catch

.replace(/\s/g, '_')
.toLowerCase()
)
Expand Down Expand Up @@ -181,7 +181,11 @@ export const NewVariableModal = (): JSX.Element => {
}
>
<div className="gap-4 flex flex-col">
<LemonField.Pure label="Name" className="gap-1">
<LemonField.Pure
label="Name"
className="gap-1"
info="Variable name must be alphanumeric and can only contain spaces and underscores"
>
<LemonInput
placeholder="Name"
value={variable.name}
Expand Down
4 changes: 2 additions & 2 deletions posthog/api/insight_variable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ def create(self, validated_data):
validated_data["team_id"] = self.context["team_id"]
validated_data["created_by"] = self.context["request"].user

# Strips non alphanumeric values from name (other than spaces)
# Strips non alphanumeric values from name (other than spaces and underscores)
validated_data["code_name"] = (
"".join(n for n in validated_data["name"] if n.isalnum() or n == " ").replace(" ", "_").lower()
"".join(n for n in validated_data["name"] if n.isalnum() or n == " " or n == "_").replace(" ", "_").lower()
)

count = InsightVariable.objects.filter(
Expand Down
Loading