feat(messaging): use SES tenants #39129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
37
to
40
| self.client.create_tenant_resource_association( | ||
| TenantName=tenant_name, | ||
| ResourceArn=f"arn:aws:ses:{settings.SES_REGION}:{settings.SES_ACCOUNT_ID}:identity/{domain}", | ||
| ) |
There was a problem hiding this comment.
logic: The tenant-resource association call lacks error handling, which could leave the system in an inconsistent state if tenant creation succeeds but association fails
Prompt To Fix With AI
This is a comment left during a code review.
Path: products/messaging/backend/providers/ses.py
Line: 37:40
Comment:
**logic:** The tenant-resource association call lacks error handling, which could leave the system in an inconsistent state if tenant creation succeeds but association fails
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
29
to
31
| try: | ||
| tenant_name = f"team-{team_id}" | ||
| self.client.create_tenant(TenantName=tenant_name, Tags=[{"Key": "team_id", "Value": str(team_id)}]) |
There was a problem hiding this comment.
style: AWS tenant names have specific constraints (3-64 characters, alphanumeric and hyphens). Consider validating the generated tenant name meets these requirements
Prompt To Fix With AI
This is a comment left during a code review.
Path: products/messaging/backend/providers/ses.py
Line: 29:31
Comment:
**style:** AWS tenant names have specific constraints (3-64 characters, alphanumeric and hyphens). Consider validating the generated tenant name meets these requirements
How can I resolve this? If you propose a fix, please make it concise.
MarconLP
approved these changes
Oct 4, 2025
…/messaging-ses-multi-tenant
…PostHog/posthog into feat/messaging-ses-multi-tenant
…PostHog/posthog into feat/messaging-ses-multi-tenant
…/messaging-ses-multi-tenant
…PostHog/posthog into feat/messaging-ses-multi-tenant
havenbarnes
added a commit
that referenced
this pull request
Oct 9, 2025
This reverts commit 046a01f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We're not using Tenants yet, a newer feature of SES that will give us better observability on customer-by-customer deliverability metrics
Changes
Adds a couple of calls to create a tenant for a team ID and associate new domains with it
How did you test this code?
TBD