Skip to content

Conversation

@havenbarnes
Copy link
Contributor

@havenbarnes havenbarnes commented Oct 3, 2025

Problem

We don't seem to be parsing single-SNS event callbacks properly. Here's a real example from Loki:

image

Changes

Fix parsing

How did you test this code?

Added unit tests for parsing behavior so we have can start to form a baseline understanding of SNS webhook body shape

Changelog: (features only) Is this feature complete?

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@posthog-bot posthog-bot requested review from a team October 3, 2025 22:21
@havenbarnes havenbarnes merged commit e00ed5a into master Oct 6, 2025
184 checks passed
@havenbarnes havenbarnes deleted the fix/messaging-ses-webhook-parsing branch October 6, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants