feat: upgrade and downgrade confirmation modals #39275
Conversation
a-lider
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
Size Change: -2.19 kB (-0.07%) Total Size: 3.05 MB
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
| <CreateProjectModal isVisible={isCreateProjectModalShown} onClose={hideCreateProjectModal} /> | ||
| <CreateEnvironmentModal isVisible={isCreateEnvironmentModalShown} onClose={hideCreateEnvironmentModal} /> | ||
| <UpgradeModal /> | ||
| <ConfirmUpgradeModal /> |
There was a problem hiding this comment.
I don't think you can remove this because it may be used in onboarding so it needs to be mounted here. You should confirm.
There was a problem hiding this comment.
Double-checked, the global ConfirmUpgradeModal is not used anymore.
Upgrade flow in the onboarding goes like this:
OnboardingUpgradeSteprendersPlanCards- "Unlock all features"click on
PlanCardscallsstartPaymentEntryFlow(payment modal)
a-lider
force-pushed
the
alex/feat/plan-switch/confirm-modal
branch
2 times, most recently
from
09156b9 to
8a62a70
Compare
Final version: |
|
And added events for downgrade/upgrade clicks to calculate the funnel |
📸 UI snapshots have been updated8 snapshot changes in total. 0 added, 8 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
I initially changed the formatting of proratedAmount to make it more readable, but in this case, users are charged without confirmation, might be better to show the exact amount. I'll revert that.
a-lider
force-pushed
the
alex/feat/plan-switch/confirm-modal
branch
from
56b4054 to
7fa8880
Compare
📸 UI snapshots have been updated8 snapshot changes in total. 0 added, 8 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
Nah, the border doesn't feel better when there's just one addon card. I'll revert and polish it later
a-lider
force-pushed
the
alex/feat/plan-switch/confirm-modal
branch
from
7ffa596 to
4ed22fa
Compare
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Problem
Building on top of #39131.
Subscription updates involve non-trivial calculations, so it's important to add a confirmation flow with clear communication about how much will be charged and when.
Changes
Confirmation Modals
ConfirmUpgradeModalto not confuse anyone.Prorated Amount Refactor
billingProductLogicselector.useMemowithgetProration()utility function, which was verbose and difficult to reuse.proratedAmountandunusedPlatformAddonAmount, so it's easier to show them in the modals.How did you test this code?
Locally
switch-subscription-planfeature flag (release toggle) is enabled