Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade hasql-pool #2391

Closed
wants to merge 13 commits into from
Closed

Upgrade hasql-pool #2391

wants to merge 13 commits into from

Commits on Aug 24, 2022

  1. refactor: rename releasePool to flushPool and document its intended b… 

    …ehaviour
    @robx
    robx committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    4b24599 View commit details
    Browse the repository at this point in the history

  2. refactor: more accurate naming and documentation for connectionStatus

    @robx
    robx committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    bcb9a1d View commit details
    Browse the repository at this point in the history

  3. fix AppState field documentation

    @robx
    robx committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    022e7ca View commit details
    Browse the repository at this point in the history

  4. upgrade to hasql-pool 0.7.2, adding pool replacement logic (fixes Pos… 

    …tgREST#2401)

This version of hasql-pool is a simplified rewrite that doesn't use
the resource-pool package. The major API changes are that idle
connections are no longer timed out (and the corresponding setting
is gone), and that `release` makes the pool unusable, where it used
to remain usable and only flushed idle connections.

- This change removes the db-pool-timeout option, since new
  hasql-pool doesn't provide timing out of idle connections.
  Given that we were typically running with very high
  timeout settings, I don't anticipate the lack of timeout
  to introduce new issues, though we might want to consider
  introducing some retry-logic down the line when we
  encounter connection failures.
- To recover the ability to flush idle connections, we add a
  somewhat painful pool wrapper that allows replacing the
  pool. This fixes PostgREST#2401 by ensuring that flushing the pool
  also prevents any active connections from being reused in
  the future.
    @robx
    robx committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    c892a4e View commit details
    Browse the repository at this point in the history

  5. tests: update app settings test 

    The original test no longer makes sense since connections don't
timeout. To somehow test that new connections have the settings,
convert it to flush the pool instead.
    @robx
    robx committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    057e326 View commit details
    Browse the repository at this point in the history

  6. address linter complaints

    @robx
    robx committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    b589495 View commit details
    Browse the repository at this point in the history

  7. comment that in-use connections aren't affected

    @robx
    robx committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    67cbe5b View commit details
    Browse the repository at this point in the history

  8. add test to validate that requests survive SIGUSR1

    @robx
    robx committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    fcb3e5b View commit details
    Browse the repository at this point in the history

  9. log flushed pool retry

    @robx
    robx committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    e3726b0 View commit details
    Browse the repository at this point in the history

  10. bump hasql-pool

    @robx
    robx committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    2f9c60e View commit details
    Browse the repository at this point in the history

  11. unbumb hasql-pool

    @robx
    robx committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    1623591 View commit details
    Browse the repository at this point in the history

  12. dontCheck hasql-pool

    @robx
    robx committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    72f61ab View commit details
    Browse the repository at this point in the history

  13. style

    @robx
    robx committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    84f4b4a View commit details
    Browse the repository at this point in the history