tests: add tests for statement_timeout#2394
Merged
robx merged 1 commit intoPostgREST:mainfrom Jul 29, 2022
Merged
Conversation
The new tests verify that: - statement_timeout on the authenticator role works to cancel slow statements - changes to statement_timeout take effect on SIGUSR1 This reuses the old "limited_authenticator" role and adds some plumbing to allow reliably changing the statement timeout even if the current role is not functional due to a low statement timeout, and to make tests that modify the role independent from each other. - introduce module-wide metapostgrest fixture to have an out-of-band way to manipulate the database, without having to spin up extra postgrest instances per test - reset statement_timeout at the start of the respective tests
steve-chavez
approved these changes
Jul 29, 2022
Member
steve-chavez
left a comment
steve-chavez
left a comment
There was a problem hiding this comment.
New metapostgrest looks awesome 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compare the discussion in #2391.
The new tests verify that:
This reuses the old "limited_authenticator" role and adds some plumbing to
allow reliably changing the statement timeout even if the current role is
not functional due to a low statement timeout, and to make tests that modify
the role independent from each other.
manipulate the database, without having to spin up extra postgrest instances
per test