refactor code interacting with pool for consistency, and misc fixes#2398
Merged
robx merged 9 commits intoPostgREST:mainfrom Aug 2, 2022
Merged
refactor code interacting with pool for consistency, and misc fixes#2398robx merged 9 commits intoPostgREST:mainfrom
robx merged 9 commits intoPostgREST:mainfrom
Conversation
Previously, postgrest-style would reformat python files, but their formatting wasn't enforced.
This prepares for wrapping the pool in a reference.
This is a bit ugly, it would be a bit nicer to just pass 'AppState.usePool appState' but then the types get messy. Or we could introduce our own 'Pool' wrapper type.
steve-chavez
approved these changes
Aug 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Largely, this collects all interaction with the connection pool in AppState helpers
usePoolandreleasePool. (It's not obviously better to useAppState.usePoolin place ofSQL.use . AppState.getPool, but for now this approach is more consistent than what we had before, and will allow easily doing things like putting the pool in an IORef in the context of #2391.)