Fix computed relationships with non SETOF return #2540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 27, 2022
wolfgangwalther
force-pushed
the
non-setof-computed-rels
branch
from
ef774a6
to
61a8393
Compare
Fixes PostgREST#2481 Signed-off-by: Wolfgang Walther <[email protected]>
wolfgangwalther
force-pushed
the
non-setof-computed-rels
branch
from
61a8393
to
4005984
Compare
steve-chavez
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2481.
We should still advertise the usage of
SETOFandROWS 1in the docs, because that's the better choice for inlining. Still, making the non-SETOF case "just work" seems like a good idea.(Based on #2539, only last commit is relevant)