fix: Prefer: missing=default with DOMAIN defaults #2843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-chavez
commented
Jun 30, 2023
| END AS column_default,|] | ||
| | otherwise = "pg_get_expr(ad.adbin, ad.adrelid)::text as column_default," | ||
| END|] | ||
| | otherwise = [q| |
There was a problem hiding this comment.
Don't get why this line is not covered in codecov. It runs when using postgrest-with-postgresql-9.6 postgrest-test-spec. I've double checked the test fails when removing it.
There was a problem hiding this comment.
Ah, code coverage only covers pg 15:
postgrest/.github/workflows/ci.yaml
Lines 46 to 51 in 0a1564b
There was a problem hiding this comment.
Noted this on #1719 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2840.