Add Preference-Applied header in response for Prefer: return=representation/headers-only/minimal #2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taimoorzaeem
force-pushed
the
issue740
branch
2 times, most recently
from
9e25c56
to
7718c32
Compare
steve-chavez
reviewed
Aug 1, 2023
steve-chavez
reviewed
Aug 1, 2023
steve-chavez
reviewed
Aug 1, 2023
steve-chavez
reviewed
Aug 1, 2023
steve-chavez
reviewed
Aug 1, 2023
steve-chavez
reviewed
Aug 4, 2023
steve-chavez
reviewed
Aug 4, 2023
…presentation/minimal/headers-only
Comment on lines
300
to
305
| -- | Add headers not already included to allow the user to override them instead of duplicating them | ||
| addHeadersIfNotIncluded :: [HTTP.Header] -> [HTTP.Header] -> [HTTP.Header] | ||
| addHeadersIfNotIncluded newHeaders initialHeaders = | ||
| filter (\(nk, _) -> isNothing $ find (\(ik, _) -> ik == nk) initialHeaders) newHeaders ++ | ||
| filter (\(nk, nv) -> isNothing $ find (\(ik, iv) -> ik == nk && nv == iv) initialHeaders) newHeaders ++ | ||
| initialHeaders | ||
|
|
There was a problem hiding this comment.
The comment says that it prevents duplication of headers. Seems like this is broken (see #2915). Maybe we should add some doc tests to this function to prove it still does what the comment says...
There was a problem hiding this comment.
Ahh! I initially did that to allow multiple Preference-Applied, however I forgot to change that back later. I'll send a PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #740.