Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix #2524 by upgrading hasql-notifications. #2909

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

diogob
Copy link
Contributor

@diogob diogob commented Aug 19, 2023

This pushes the solution proposed in #2906 upstream (diogob/hasql-notifications#18)

@diogob
Copy link
Contributor Author

diogob commented Aug 19, 2023

@laurenceisla I could not build PostgREST on my Windows VM. Could you confirm if this branch has the problem solved?

@steve-chavez
Copy link
Member

@diogob Thanks for jumping in to help!

The CI faliures look related to Nix, we'll need to update nixpkgs to a recent version (recent previous attempt #2891)

@laurenceisla
Copy link
Member

laurenceisla commented Aug 20, 2023

@laurenceisla I could not build PostgREST on my Windows VM. Could you confirm if this branch has the problem solved?

@diogob Excellent! Can confirm that in this branch the notifications work, while in main they do not.

BTW, using Stack (installed with GHCup) to build PostgREST in Windows worked for me.

 stack build --local-bin-path result --copy-bins

@diogob diogob marked this pull request as ready for review August 21, 2023 14:17
@laurenceisla laurenceisla merged commit b8b3145 into PostgREST:main Aug 21, 2023
19 of 21 checks passed
@diogob diogob deleted the fix-notify-windows branch August 21, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants