add: override PGRST_CMD for postgrest-loadtest from env #4219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
The above is real nice, we can use it to improve perf. Looking at this #4220 (comment), is this PR dependent on #4220? Or how do you confirm this PR is working as expected? |
Collaborator
Author
It doesn't depend on #4220, I've merely used |
develop7
force-pushed
the
add-loadtest_override_cmd
branch
from
2959cb6 to
aba9623
Compare
develop7
force-pushed
the
add-loadtest_override_cmd
branch
2 times, most recently
from
03ebc68 to
0d77a4d
Compare
develop7
force-pushed
the
add-loadtest_override_cmd
branch
from
0d77a4d to
2dfed6a
Compare
develop7
force-pushed
the
add-loadtest_override_cmd
branch
4 times, most recently
from
2b97208 to
3ba2b15
Compare
develop7
force-pushed
the
add-loadtest_override_cmd
branch
from
3ba2b15 to
66729e7
Compare
Enables `PGRST_CMD=postgrest-profiled-run postgrest-loadtest` running loadtest against profiled executable, which wasn't available before
develop7
force-pushed
the
add-loadtest_override_cmd
branch
from
66729e7 to
5b6039f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables overriding postgrest executable with
PGRST_CMDenvironment variable inpostgrest-loadtestscript. This enables, for example, running loadtest against profiled executable with simplePGRST_CMD=postgrest-profiled-run postgrest-loadtest, which wasn't possible before, becausePGRST_CMDwas defined internally.