Add the GitHub mark to the sign-in button - #4
Merged
Conversation
The provider's mark renders inline before the label (currentColor, so it's dark on the amber primary / light on a secondary) and is hidden while that button is submitting so the loading spinner replaces it. Decorative (aria-hidden) — the button text carries the accessible name.
PouyanJay
added a commit
that referenced
this pull request
Jul 5, 2026
… sessions in the list - Concurrent permission gates (#4 "stuck"): the session view's approve/reject discarded the clicked gate's requestId and resolved the FIRST pending gate instead. With several gates open at once (parallel tool calls) the operator's click landed on the wrong request — it read as "nothing happened / stuck", which also drove the "had to reopen to see progress" symptom. Thread each gate's requestId through onDecide, matching how question/handover answers already work. onDecide now requires a requestId, so the type prevents a regression. - Chained sessions (#2): a forked continuation was only marked inside the session view ("continued from" / "view continuation"). The dashboard list now marks it too with a "continuation" pill, via a new isContinuation on the row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Continue with GitHub" button was text-only. This adds the GitHub mark inline before the label.
fill="currentColor", so it's dark on the amber primary button and light on a secondary — no extra color tokens.aria-hidden+focusable="false"; the button text "Continue with GitHub" is the accessible name.Gates: svelte-check (0 errors), lint, format, web tests — all green.