Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: add support for a callback when a new tickets key is added #14327

Merged
merged 9 commits into from
Jul 4, 2024
Merged

dnsdist: add support for a callback when a new tickets key is added #14327

merged 9 commits into from
Jul 4, 2024

Conversation

chbruyand
Copy link
Member

@chbruyand chbruyand commented Jun 14, 2024 •
edited
Loading

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@coveralls
Copy link

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9518942957

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2016 unchanged lines in 68 files lost coverage.
  • Overall coverage decreased (-1.7%) to 62.987%
Files with Coverage Reduction New Missed Lines %
pdns/webserver.hh 1 66.33%
pdns/cachecleaner.hh 1 75.63%
pdns/backends/gsql/gsqlbackend.hh 2 97.71%
pdns/ws-api.cc 2 84.91%
ext/yahttp/yahttp/utility.hpp 2 36.53%
pdns/burtle.hh 2 96.32%
pdns/views.hh 2 80.0%
pdns/channel.hh 2 51.75%
pdns/pollmplexer.cc 2 83.01%
pdns/proxy-protocol.cc 2 73.63%
Totals Coverage Status
Change from base Build 9498441929: -1.7%
Covered Lines: 41757
Relevant Lines: 59509
💛 - Coveralls

@rgacogne rgacogne self-requested a review June 17, 2024 07:06
@rgacogne rgacogne added this to the dnsdist-2.0.0 milestone Jun 17, 2024
@coveralls
Copy link

coveralls commented Jun 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9697223695

Details

  • 0 of 22 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1850 unchanged lines in 53 files lost coverage.
  • Overall coverage increased (+1.6%) to 66.273%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/tcpiohandler.hh 0 9 0.0%
pdns/libssl.cc 0 13 0.0%
Files with Coverage Reduction New Missed Lines %
modules/gpgsqlbackend/gpgsqlbackend.cc 1 88.62%
pdns/recursordist/aggressive_nsec.cc 2 66.39%
pdns/epollmplexer.cc 2 83.13%
pdns/libssl.hh 2 0.0%
ext/yahttp/yahttp/utility.hpp 2 36.53%
pdns/burtle.hh 2 96.93%
modules/lmdbbackend/lmdbbackend.cc 2 73.5%
pdns/channel.hh 2 53.26%
pdns/pollmplexer.cc 2 83.01%
pdns/proxy-protocol.cc 2 76.03%
Totals Coverage Status
Change from base Build 9680344555: 1.6%
Covered Lines: 84792
Relevant Lines: 112568
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9697466876

Details

  • 0 of 22 (0.0%) changed or added relevant lines in 2 files are covered.
  • 2065 unchanged lines in 64 files lost coverage.
  • Overall coverage increased (+1.3%) to 66.052%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/tcpiohandler.hh 0 9 0.0%
pdns/libssl.cc 0 13 0.0%
Files with Coverage Reduction New Missed Lines %
pdns/validate.cc 1 67.95%
pdns/recursordist/recursor_cache.cc 1 85.89%
pdns/epollmplexer.cc 2 81.88%
pdns/libssl.hh 2 0.0%
ext/yahttp/yahttp/utility.hpp 2 36.53%
pdns/burtle.hh 2 96.93%
modules/lmdbbackend/lmdbbackend.cc 2 73.5%
pdns/channel.hh 2 53.26%
pdns/pollmplexer.cc 2 83.01%
pdns/proxy-protocol.cc 2 76.03%
Totals Coverage Status
Change from base Build 9680344555: 1.3%
Covered Lines: 84615
Relevant Lines: 112618
💛 - Coveralls

rgacogne
rgacogne requested changes Jun 28, 2024
View reviewed changes
Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! I made a few suggestions but apart from the version number the rest is just nitpicking.

pdns/dnsdistdist/dnsdist-lua-hooks.cc Outdated Show resolved Hide resolved
pdns/dnsdistdist/dnsdist-lua-hooks.hh Outdated Show resolved Hide resolved
pdns/dnsdistdist/docs/reference/config.rst Outdated Show resolved Hide resolved
pdns/libssl.cc Show resolved Hide resolved
pdns/tcpiohandler.cc Show resolved Hide resolved
pdns/tcpiohandler.cc Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jun 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9710022713

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 22 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1875 unchanged lines in 55 files lost coverage.
  • Overall coverage increased (+1.6%) to 66.298%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/tcpiohandler.hh 0 9 0.0%
pdns/libssl.cc 0 13 0.0%
Files with Coverage Reduction New Missed Lines %
modules/gpgsqlbackend/gpgsqlbackend.cc 1 88.62%
pdns/recursordist/syncres.cc 1 79.71%
pdns/recursordist/sortlist.cc 2 72.94%
pdns/recursordist/aggressive_nsec.cc 2 66.32%
pdns/epollmplexer.cc 2 83.13%
pdns/backends/gsql/gsqlbackend.hh 2 97.71%
pdns/libssl.hh 2 0.0%
ext/yahttp/yahttp/utility.hpp 2 36.53%
pdns/burtle.hh 2 96.93%
pdns/channel.hh 2 53.26%
Totals Coverage Status
Change from base Build 9680344555: 1.6%
Covered Lines: 84837
Relevant Lines: 112579
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9710133612

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 22 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1878 unchanged lines in 53 files lost coverage.
  • Overall coverage increased (+1.6%) to 66.278%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/tcpiohandler.hh 0 9 0.0%
pdns/libssl.cc 0 13 0.0%
Files with Coverage Reduction New Missed Lines %
modules/gpgsqlbackend/gpgsqlbackend.cc 1 88.62%
pdns/validate.cc 1 68.14%
pdns/epollmplexer.cc 2 83.13%
pdns/libssl.hh 2 0.0%
ext/yahttp/yahttp/utility.hpp 2 36.53%
pdns/burtle.hh 2 96.93%
modules/lmdbbackend/lmdbbackend.cc 2 73.46%
pdns/channel.hh 2 53.26%
pdns/pollmplexer.cc 2 83.01%
pdns/proxy-protocol.cc 2 76.03%
Totals Coverage Status
Change from base Build 9680344555: 1.6%
Covered Lines: 84812
Relevant Lines: 112579
💛 - Coveralls

@chbruyand chbruyand marked this pull request as ready for review July 2, 2024 14:44
rgacogne
rgacogne approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks! I'll merge it once CI is green.

@coveralls
Copy link

coveralls commented Jul 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9763102220

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 23 (0.0%) changed or added relevant lines in 2 files are covered.
  • 2546 unchanged lines in 61 files lost coverage.
  • Overall coverage increased (+1.6%) to 66.269%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/tcpiohandler.hh 0 9 0.0%
pdns/libssl.cc 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
pdns/recursordist/sortlist.cc 2 74.12%
pdns/recursordist/aggressive_nsec.cc 2 66.32%
pdns/epollmplexer.cc 2 83.13%
pdns/libssl.hh 2 0.0%
ext/yahttp/yahttp/utility.hpp 2 36.53%
pdns/burtle.hh 2 96.93%
pdns/channel.hh 2 53.26%
pdns/pollmplexer.cc 2 83.01%
pdns/proxy-protocol.cc 2 76.03%
pdns/recursordist/test-syncres_cc2.cc 3 88.91%
Totals Coverage Status
Change from base Build 9680344555: 1.6%
Covered Lines: 84827
Relevant Lines: 112634
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9773443469

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2009 unchanged lines in 67 files lost coverage.
  • Overall coverage decreased (-1.5%) to 63.009%
Files with Coverage Reduction New Missed Lines %
pdns/webserver.hh 1 66.33%
pdns/pollmplexer.cc 1 83.01%
pdns/cachecleaner.hh 2 75.25%
pdns/ws-api.cc 2 84.91%
ext/yahttp/yahttp/utility.hpp 2 36.53%
pdns/burtle.hh 2 96.32%
pdns/ws-auth.cc 2 80.78%
pdns/channel.hh 2 51.75%
pdns/proxy-protocol.cc 2 73.63%
pdns/stubresolver.cc 3 77.58%
Totals Coverage Status
Change from base Build 9762364246: -1.5%
Covered Lines: 41791
Relevant Lines: 59559
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9776942173

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 23 (0.0%) changed or added relevant lines in 2 files are covered.
  • 8596 unchanged lines in 89 files lost coverage.
  • Overall coverage decreased (-1.5%) to 62.998%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/tcpiohandler.hh 0 9 0.0%
pdns/libssl.cc 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
pdns/pollmplexer.cc 1 83.01%
pdns/recursordist/sortlist.cc 2 74.12%
pdns/epollmplexer.cc 2 83.13%
pdns/libssl.hh 2 0.0%
ext/yahttp/yahttp/utility.hpp 2 36.53%
pdns/burtle.hh 2 97.55%
pdns/dnsdistdist/dnsdist-lua-bindings-kvs.cc 2 0.0%
pdns/dnsdistdist/dnsdist-lua-bindings-dnsquestion.cc 2 0.0%
pdns/ws-auth.cc 2 80.78%
pdns/channel.hh 2 45.89%
Totals Coverage Status
Change from base Build 9762364246: -1.5%
Covered Lines: 104563
Relevant Lines: 144026
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9777912267

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 62 of 64 (96.88%) changed or added relevant lines in 5 files are covered.
  • 393 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.2%) to 64.707%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/dnsdistdist/dnsdist-lua-hooks.cc 13 15 86.67%
Files with Coverage Reduction New Missed Lines %
pdns/recursordist/sortlist.cc 2 72.94%
pdns/sstuff.hh 2 56.83%
pdns/stubresolver.cc 3 77.58%
pdns/remote_logger.cc 3 54.26%
pdns/iputils.hh 3 78.53%
pdns/recursordist/test-syncres_cc1.cc 5 89.79%
pdns/signingpipe.cc 5 85.75%
pdns/recursordist/rec-tcp.cc 10 64.56%
pdns/misc.hh 29 87.62%
pdns/dnspacket.cc 60 71.51%
Totals Coverage Status
Change from base Build 9762364246: 0.2%
Covered Lines: 124829
Relevant Lines: 162181
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9792847213

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 62 of 64 (96.88%) changed or added relevant lines in 5 files are covered.
  • 414 unchanged lines in 18 files lost coverage.
  • Overall coverage increased (+0.1%) to 64.661%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/dnsdistdist/dnsdist-lua-hooks.cc 13 15 86.67%
Files with Coverage Reduction New Missed Lines %
pdns/dnsdistdist/dnsdist-backend.cc 1 66.76%
pdns/dnsdistdist/dnsdist-crypto.cc 2 75.72%
pdns/recursordist/sortlist.cc 2 74.12%
pdns/sstuff.hh 2 56.83%
pdns/backends/gsql/gsqlbackend.hh 2 96.57%
pdns/tcpiohandler.cc 2 66.77%
pdns/stubresolver.cc 3 77.58%
pdns/iputils.hh 3 78.57%
pdns/recursordist/test-syncres_cc1.cc 5 89.67%
pdns/iputils.cc 6 54.53%
Totals Coverage Status
Change from base Build 9762364246: 0.1%
Covered Lines: 124756
Relevant Lines: 162179
💛 - Coveralls

@rgacogne rgacogne merged commit d1ac698 into PowerDNS:master Jul 4, 2024
79 checks passed
@omoerbeek omoerbeek mentioned this pull request Jul 4, 2024
Merged
7 tasks
@rgacogne rgacogne mentioned this pull request Jul 9, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgacogne rgacogne rgacogne approved these changes

Assignees
No one assigned
Labels
dnsdist enhancement
Projects
None yet
Milestone
dnsdist-2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@chbruyand @coveralls @rgacogne