Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C api and unit tests for vnf converter #15

Merged
merged 31 commits into from
Oct 30, 2024
Merged

C api and unit tests for vnf converter #15

merged 31 commits into from
Oct 30, 2024

Conversation

Laurynas-Jagutis
Copy link
Member

No description provided.

@Laurynas-Jagutis
add experimental feature flag, add test files, adjust cmake for tests…
2631f1f 
…, add unit tests

Signed-off-by: Laurynas Jagutis <[email protected]>
@Laurynas-Jagutis
Merge remote-tracking branch 'origin/main' into feature/c-tests
eb51b8d
@Laurynas-Jagutis
adjust c api test file
65e491c 
Signed-off-by: Laurynas Jagutis <[email protected]>
@Laurynas-Jagutis
Merge remote-tracking branch 'origin/main' into feature/c-tests
5b4598a
@Laurynas-Jagutis
add call with catch in c api, add tests
943e7d0 
Signed-off-by: Laurynas Jagutis <[email protected]>
@Laurynas-Jagutis
fix tests, fix some warnings
7b6ce9c 
Signed-off-by: Laurynas Jagutis <[email protected]>
@Laurynas-Jagutis
fix clang tidy warnings
0eda749 
Signed-off-by: Laurynas Jagutis <[email protected]>
@Laurynas-Jagutis
add an include
b489cdc 
Signed-off-by: Laurynas Jagutis <[email protected]>
@Laurynas-Jagutis
const
b821a74 
Signed-off-by: Laurynas Jagutis <[email protected]>
@Laurynas-Jagutis
const
2f50ad9 
Signed-off-by: Laurynas Jagutis <[email protected]>
mgovers
mgovers reviewed Oct 23, 2024
View reviewed changes
..._grid_model_io_native/include/power_grid_model_io_native/vnf_converter/vnf_pgm_converter.hpp Outdated Show resolved Hide resolved
..._grid_model_io_native/include/power_grid_model_io_native/vnf_converter/vnf_pgm_converter.hpp Outdated Show resolved Hide resolved
..._grid_model_io_native/include/power_grid_model_io_native/vnf_converter/vnf_pgm_converter.hpp Outdated Show resolved Hide resolved
..._grid_model_io_native/include/power_grid_model_io_native/vnf_converter/vnf_pgm_converter.hpp Outdated Show resolved Hide resolved
..._grid_model_io_native/include/power_grid_model_io_native/vnf_converter/vnf_pgm_converter.hpp Outdated Show resolved Hide resolved
power_grid_model_io_native_c/power_grid_model_io_native_c/src/vnf_pgm_converter.cpp Outdated Show resolved Hide resolved
..._grid_model_io_native/include/power_grid_model_io_native/vnf_converter/vnf_pgm_converter.hpp Outdated Show resolved Hide resolved
tests/c_api_tests/test_c_api_vnf_converter.cpp Outdated Show resolved Hide resolved
tests/c_api_tests/test_c_api_vnf_converter.cpp Outdated Show resolved Hide resolved
figueroa1395
figueroa1395 reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@figueroa1395 figueroa1395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the sonar cloud issues, they should be very easy to resolve (the one related to new can probably be silenced, or ignored). Everything else looks good.

tests/c_api_tests/test_c_api_vnf_converter.cpp Outdated Show resolved Hide resolved
tests/cpp_unit_tests/test_pgm_vnf_converter.cpp Outdated Show resolved Hide resolved
tests/cpp_unit_tests/test_pgm_vnf_converter.cpp Outdated Show resolved Hide resolved
tests/cpp_unit_tests/test_pgm_vnf_converter.cpp Outdated Show resolved Hide resolved
@Laurynas-Jagutis
add enum, remove writable dataset from c api, adjust tests accordingly
d5f0b7d 
Signed-off-by: Laurynas Jagutis <[email protected]>
@Laurynas-Jagutis
make json_string global in tests
6ebd5dc 
Signed-off-by: Laurynas Jagutis <[email protected]>
@Laurynas-Jagutis
change deserialized data into deserialized_data
e6476f8 
Signed-off-by: Laurynas Jagutis <[email protected]>
@Laurynas-Jagutis
change getter and setter names for deserialized data
ccbf574 
Signed-off-by: Laurynas Jagutis <[email protected]>
@Laurynas-Jagutis
initialize uninitialized member value
3e0ef03 
Signed-off-by: Laurynas Jagutis <[email protected]>
@Laurynas-Jagutis
change default init
9fcabab 
Signed-off-by: Laurynas Jagutis <[email protected]>
@Laurynas-Jagutis
add auto and const to experimental features
0acbca9 
Signed-off-by: Laurynas Jagutis <[email protected]>
@Laurynas-Jagutis
add const to get_file_buffer
6ca0706 
Signed-off-by: Laurynas Jagutis <[email protected]>
@Laurynas-Jagutis
add const to get_file_buffer1
37cfde4 
Signed-off-by: Laurynas Jagutis <[email protected]>
@Laurynas-Jagutis
const
26a4249 
Signed-off-by: Laurynas Jagutis <[email protected]>
@Laurynas-Jagutis
setup a full test for getter and setter of deserialied_data
9339208 
Signed-off-by: Laurynas Jagutis <[email protected]>
@mgovers
Copy link
Member

mgovers commented Oct 29, 2024

I think this is ready for full review, right? Looks like everything is OK

@Laurynas-Jagutis Laurynas-Jagutis marked this pull request as ready for review October 30, 2024 07:20
@Laurynas-Jagutis
shorten test names
3d8b19b 
Signed-off-by: Laurynas Jagutis <[email protected]>
@Laurynas-Jagutis
remove unnecessary casting
a80e95c 
Signed-off-by: Laurynas Jagutis <[email protected]>
@Laurynas-Jagutis
add switch/case
cd10d1b 
Signed-off-by: Laurynas Jagutis <[email protected]>
@Laurynas-Jagutis
initialize experimental feature fully because of clang tidy
226aac9 
Signed-off-by: Laurynas Jagutis <[email protected]>
@Laurynas-Jagutis
use using enum
d7c94b1 
Signed-off-by: Laurynas Jagutis <[email protected]>
@Laurynas-Jagutis
change namespace usage
1db9a92 
Signed-off-by: Laurynas Jagutis <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 30, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mgovers mgovers added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit e2ad0ca Oct 30, 2024
25 checks passed
@mgovers mgovers deleted the feature/c-tests branch October 30, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@figueroa1395 figueroa1395 figueroa1395 left review comments

@mgovers mgovers mgovers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Laurynas-Jagutis @mgovers @figueroa1395