Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vision conversion for tap changer #252

Merged
merged 21 commits into from
Jun 28, 2024
Merged

vision conversion for tap changer #252

merged 21 commits into from
Jun 28, 2024

Conversation

nitbharambe
Copy link
Member

@nitbharambe nitbharambe commented Jun 3, 2024 •
edited
Loading

Vision Conversion for automatic tap changer

TODOs:

  • Update validation tests
  • update pgm version

@nitbharambe
add conversion information
bb91233 
Signed-off-by: Nitish Bharambe <[email protected]>
@nitbharambe nitbharambe changed the base branch from main to feature/filtering-option June 24, 2024 11:22
Base automatically changed from feature/filtering-option to main June 25, 2024 11:26
@nitbharambe
filter exception tests
e05bff8 
Signed-off-by: Nitish Bharambe <[email protected]>
@nitbharambe
increase pgm requirement
3e84d6a 
Signed-off-by: Nitish Bharambe <[email protected]>
@nitbharambe
add unsupported info
12b5466 
Signed-off-by: Nitish Bharambe <[email protected]>
@nitbharambe
fix auto id conversion
140e0b3 
Signed-off-by: Nitish Bharambe <[email protected]>
@nitbharambe
remove name from main obj
54275aa 
Signed-off-by: Nitish Bharambe <[email protected]>
@nitbharambe
97 sheet name change
cbaf7d1 
Signed-off-by: Nitish Bharambe <[email protected]>
@nitbharambe
Revert "97 sheet name change"
23d8d29 
This reverts commit cbaf7d1.
@nitbharambe
DCO Remediation Commit for Nitish Bharambe <nitish.bharambe@alliander…
0dc48cd 
….com>

I, Nitish Bharambe <[email protected]>, hereby add my Signed-off-by to this commit: 23d8d29

Signed-off-by: Nitish Bharambe <[email protected]>
@nitbharambe nitbharambe marked this pull request as ready for review June 27, 2024 07:06
nitbharambe and others added 2 commits June 28, 2024 09:45
@nitbharambe @Jerry-Jinfeng-Guo
Update tests/unit/utils/test_uuid_excel_cvtr.py
00f31b7 
Co-authored-by: Jerry Guo <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
@nitbharambe
fix typo
802c1db 
Signed-off-by: Nitish Bharambe <[email protected]>
mgovers
mgovers reviewed Jun 28, 2024
View reviewed changes
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only this is left. Fine with everything else

docs/converters/vision_converter.md Outdated Show resolved Hide resolved
@nitbharambe @mgovers
Update docs/converters/vision_converter.md
acc20b0 
Co-authored-by: Martijn Govers <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
@nitbharambe @Jerry-Jinfeng-Guo
Update docs/converters/vision_converter.md
2df8fcb 
Co-authored-by: Jerry Guo <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@nitbharambe nitbharambe added this pull request to the merge queue Jun 28, 2024
Merged via the queue into main with commit d160375 Jun 28, 2024
31 checks passed
@nitbharambe nitbharambe deleted the feature/vision-tap-regulator-conversion branch June 28, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgovers mgovers mgovers left review comments

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitbharambe @Jerry-Jinfeng-Guo @mgovers