Observability: add finer grained unit test for both existing radial check and new meshed check #1146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jerry Guo <[email protected]>
Jerry-Jinfeng-Guo
added
feature
Jerry-Jinfeng-Guo
changed the base branch from
main
to
feature/full-observability-check-meshed-network-without-voltage-phasor
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive unit tests for individual functions within the observability module, focusing on more granular function-level testing compared to the existing integration tests. The tests cover radial check functions and provide groundwork for future meshed check function testing.
Key changes:
- Adds unit tests for all major functions in the observability module including
scan_network_sensors,prepare_starting_nodes,expand_neighbour_list,assign_independent_sensors_radial,starting_from_node,necessary_condition, and both sufficient condition functions - Maintains dependency on mathematical topology and
YBusStructurefor practical testing - Provides extensive test coverage with various scenarios including edge cases, error conditions, and different network topologies
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mgovers
reviewed
Oct 7, 2025
Signed-off-by: Jerry Guo <[email protected]>
|
|
…eaking in core logic is sound Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
…-voltage-phasor' into feature/unit-test-observability-check
Signed-off-by: Jerry Guo <[email protected]>
…-voltage-phasor' into feature/unit-test-observability-check
…-voltage-phasor' into feature/unit-test-observability-check
…-voltage-phasor' into feature/unit-test-observability-check
figueroa1395
reviewed
Oct 9, 2025
Signed-off-by: Jerry Guo <[email protected]>
…-voltage-phasor' into feature/unit-test-observability-check
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
…date and reassignment Signed-off-by: Jerry Guo <[email protected]>
…-voltage-phasor' into feature/unit-test-observability-check
figueroa1395
previously approved these changes
Oct 16, 2025
Signed-off-by: Jerry Guo <[email protected]>
…-voltage-phasor' into feature/unit-test-observability-check
|
|
|
Base automatically changed from
feature/full-observability-check-meshed-network-without-voltage-phasor
to
main
October 21, 2025 15:35
Jerry-Jinfeng-Guo
dismissed
figueroa1395’s stale review
The base branch was changed.
figueroa1395
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit test for all functions within the observability module, related to #1136
The unit tests are added with still dependency on mathematical topology and
YBusStructure. This choice was due to the fact that when trying to wrap certain functionalities from the observability module, any mocking attempt will have to be redone. Therefore, the most straight-forward path is chosen to extend this unit test for the objective of function-level unit testing this module.